Bugfix: Keep import path and context for plugin's scss imports #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of concating all files into one gigantic file reuse the importer - and that way keep the context for relative paths in plugin scss
|
You've signed the CLA, ligthyear. Thank you! This pull request is ready for review. |
|
Thanks, lets try this out. sprockets is very voodoo |
SamSaffron
added a commit
that referenced
this pull request
Apr 11, 2014
Bugfix: Keep import path and context for plugin's scss imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of concatenating all files into one gigantic file reuse the importer by creating an intermediate "scss" containing only the
@import-statements to all plugin styles. Which then triggers a recursive call to load each individual one of them with the appropriate relative paths still in tact.Fixes https://meta.discourse.org/t/uses-of-scss-in-plugins/14644