DEV: Move all scroll position reset/remember logic to a shared service #22552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were implementing scroll reset/memorization on a per-page basis. Many of these approaches relied on the `didInsertElement` hook, which is no longer appropriate since Discourse changed to use the 'loading slider' strategy for page transitions. This commit rips out all of our custom scroll resetting/memorizing, and implements those things in a generic service. There are two features: 1. After every route transition, scroll to the top of the page 2. When using browser back/forward buttons, restore the last known scroll position for those routes
davidtaylorhq
force-pushed
the
scroll-manager
branch
from
95d3485
to
2f115f7
Compare
davidtaylorhq
commented
Jul 12, 2023
| @@ -6,6 +6,17 @@ let popstateFired = false; | |||
| const supportsHistoryState = window.history && "state" in window.history; | |||
| const popstateCallbacks = []; | |||
|
|
|||
| function _uuid() { | |||
There was a problem hiding this comment.
This 'uuid' feature is part of upstream's "history-location" routing adapter, which we eventually intend to migrate to.
CvX
reviewed
Jul 12, 2023
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
CvX
reviewed
Jul 12, 2023
jjaffeux
reviewed
Jul 12, 2023
jjaffeux
reviewed
Jul 12, 2023
jjaffeux
approved these changes
Jul 12, 2023
jjaffeux
reviewed
Jul 12, 2023
app/assets/javascripts/discourse/app/services/route-scroll-manager.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
Using the lastViewedTopicId indiscriminately can cause strange scrolling behavior when navigating to a **different** topic list after viewing a topic. We only want to refocus the topic when going 'back' to the same topic list which originally triggered the navigation.
This reverts commit a3b24bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were implementing scroll reset/memorization on a per-page basis. Many of these approaches relied on the
didInsertElementhook, which is no longer appropriate since Discourse changed to use the 'loading slider' strategy for page transitions.This commit rips out all of our custom scroll resetting/memorizing, and implements those things in a generic service. There are two features: