FIX: prevents user to restore message deleted by staff #22571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could only occur on message created by the user itself and deleted while the user was looking at the channel. It more generally fix the trash service which was not correctly setting the author of the delete.
| def trash_message(message:, **) | ||
| message.trash! | ||
| def trash_message(message:, guardian:, **) | ||
| message.trash!(guardian.user) |
There was a problem hiding this comment.
Oh damn I do forget this a lot, thanks for fixing
martin-brennan
approved these changes
Jul 13, 2023
plugins/chat/assets/javascripts/discourse/models/chat-message.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
…rse into chat/can-restore-message
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/user-can-restore-their-own-message-what-deleted-by-staff/268484/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could only occur on message created by the user itself and deleted while the user was looking at the channel.
It more generally fix the trash service which was not correctly setting the author of the delete.