FIX: Member Highlights on Group Cards #22828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3lase
force-pushed
the
fix/group-card-members-list
branch
from
7cb2906
to
d29efa9
Compare
ZogStriP
reviewed
Jul 28, 2023
app/assets/javascripts/discourse/app/components/group-card-contents.js
Outdated
Show resolved
Hide resolved
ZogStriP
approved these changes
Jul 28, 2023
By default, only 10 members are highlighted on group cards. However, joining/leaving a big group via the buttons on the group card results in up to 50 members being highlighted. For large groups, this causes the card to move off-screen. This happens because, while the initial render explicitly fetches only 10 members, we don't seem to apply the same limit as part of the member reload performed when a user leaves/joins via the buttons on the card. This PR fixes that by only making the first 10 users available for highlight regardless of the number of members loaded in the store.
s3lase
force-pushed
the
fix/group-card-members-list
branch
from
d29efa9
to
3d04014
Compare
|
Thanks @ZogStriP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, only 10 members are highlighted on group cards. However, joining/leaving a big group via the buttons on the group card results in up to 50 members being highlighted. For large groups this causes the card to move off-screen.
This happens because, while the initial render explicitly fetches only 10 members, we don't seem to apply the same limit as part of the member reload performed when a user leaves/joins via the buttons on the card.
This PR fixes that by only making the first 10 users available for highlight regardless of the number of members loaded in the store.
Before
After