FIX: Missing pending queued posts from topic view #22838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change updated `ReviewableQueuedPost`'s `created_by` to be consistent with other reviewable types. It assigns the the creator of the post being queued to `target_created_by` and sets the `created_by` to the creator of the reviewable itself. This fix updates some of the `created_by` references missed during the intial fix.
s3lase
force-pushed
the
fix/include-pending-posts-in-topic-view
branch
2 times, most recently
from
5102cc5
to
99a3239
Compare
s3lase
commented
Jul 28, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
pmusaraj
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change updated
ReviewableQueuedPost'screated_byto be consistent with other reviewable types. It assigns the the creator of the post content being queued totarget_created_byand sets thecreated_byto the creator of the reviewable itself.This fix updates some of the
created_byreferences missed during the initial fix.See 3d554aa and https://meta.discourse.org/t/awaiting-approval-post-display-issue-following-update-to-discourse-version-3-1-0-beta6/272781