FIX: Can't dismiss unread posts in topics of a sub-subcategory #22870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a similar fix to 32d4810 Why this change? Prior to this change, there is a bug in `TopicsController#bulk` where it does not dismiss new unred posts in sub-subcategories when the `category_id` and `include_subcategories=true` params are present. This is because the controller did not account for sub-subcategories when fetching the category ids of the new topics that should be dismissed. This commit fixes the problem by relying on the `Category.subcategory_ids` class method which accounts for sub-subcategories.
nattsw
reviewed
Jul 31, 2023
| end | ||
| category_ids = | ||
| if params[:include_subcategories] | ||
| Category.subcategory_ids(params[:category_id].to_i) |
There was a problem hiding this comment.
Uh just to confirm Category.subcategory_ids(params[:category_id].to_i) returns sub sub categories for a category?
There was a problem hiding this comment.
Yup it returns an array which contains the category id passed to the method as well as the ids of the sub-category and sub-sub-categories for the given category id.
|
Thank you for the review @nattsw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a similar fix to 32d4810
Why this change?
Prior to this change, there is a bug in
TopicsController#bulkwhere it does not dismiss new unred posts in sub-subcategories when the
category_idandinclude_subcategories=trueparams are present. Thisis because the controller did not account for sub-subcategories when
fetching the category ids of the new topics that should be dismissed.
This commit fixes the problem by relying on the
Category.subcategory_idsclassmethod which accounts for sub-subcategories.