Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: correctly applies aria-expanded/aria-controls #23029

Merged
merged 1 commit into from Aug 9, 2023
Merged

FIX: correctly applies aria-expanded/aria-controls #23029

merged 1 commit into from Aug 9, 2023

Conversation

jjaffeux
Copy link
Contributor

@jjaffeux jjaffeux commented Aug 9, 2023 •
edited

Prior to this fix aria-expanded would only be set to true on first open and not set to false after. Also aria-controls was not defined which is a mandatory aspect of using aria-expanded.

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Aug 9, 2023
@chapoi chapoi merged commit 3a3346c into discourse:main Aug 9, 2023
13 checks passed
@jjaffeux jjaffeux deleted the composer-dropdown-aria branch August 9, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapoi chapoi chapoi approved these changes

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
2 participants
@jjaffeux @chapoi