Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Prevent chat message actions to disappear on mouseleave #23063

Merged
merged 2 commits into from Sep 11, 2023
Merged

FIX: Prevent chat message actions to disappear on mouseleave #23063

merged 2 commits into from Sep 11, 2023

Conversation

jancernik
Copy link
Member

@jancernik jancernik commented Aug 10, 2023 •
edited

After this change, you'll need to click the button again or anywhere outside to dissmiss the "more option" dropdown in chat

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Aug 10, 2023
pmusaraj
pmusaraj approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Any chance we can add a test for this?

Also, I'm not too familiar with chat, but I do see that we use separate templates for desktop/mobile. Make sure you try out this change on mobile as well, just to be safe.

@jancernik jancernik merged commit d9a2595 into discourse:main Sep 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
2 participants
@jancernik @pmusaraj