FEATURE: add a param to exclude users by groups on the users directory page #23067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrw
approved these changes
Aug 10, 2023
tgxworld
reviewed
Aug 11, 2023
| @@ -37,6 +37,19 @@ acceptance("User Directory", function () { | |||
| ); | |||
| }); | |||
|
|
|||
| test("Visit With Group Exclusion", async function (assert) { | |||
There was a problem hiding this comment.
I'm not sure if I'm missing something but it doesn't seem like any of the assertions here are testing that groups are testing that groups are excluded?
There was a problem hiding this comment.
This is based on all the other tests of this file.
I already tested the backend on another PR.
I can improve this one if needed.
tgxworld
force-pushed
the
add-group-exclusion-to-users-index
branch
from
750f5e8
to
8b7dd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.