New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: revert previously removed mentions transformation on the client #23084
FIX: revert previously removed mentions transformation on the client #23084
Conversation
Will let @martin-brennan look at this one given he changed this code few days ago |
Ah my bad @AndrewPrigorshnev I didn't read properly and see |
@martin-brennan, great, thank you for looking into the hashtag thing! And could we merge this part for mentions first? May I have an approval on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewPrigorshnev so sorry I didn't realise I didn't approve 🤦 Go ahead and merge!
@martin-brennan, no worries! Thank you for the review and the approval. |
4e7c73d
to
b08ca91
Compare
This partially reverts 2ecc829.
The problem is that if we don't transform mentions right away, there is a noticeable lag before a mention gets fully rendered:
Screen.Recording.2023-08-14.at.19.00.22.mov
even when running locally:
Screen.Recording.2023-08-14.at.18.56.07.mov
While with this transformation, everything is super smooth:
Screen.Recording.2023-08-14.at.18.56.40.mov
I'm reverting that change only for mentions. Another part was about category hashtags, but unfortunately they lag both with and without this transformation. We need to address them separately.
cc @martin-brennan