Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Correct select-kit positioning strategy in modals #23096

Merged
merged 1 commit into from Aug 15, 2023
Merged

FIX: Correct select-kit positioning strategy in modals #23096

merged 1 commit into from Aug 15, 2023

Commits on Aug 15, 2023

  1. FIX: Correct select-kit positioning strategy in modals 

    The new modal API removed the `#discourse-modal` id from the wrapper element, which meant that select-kit couldn't properly detect when it was inside a modal. This commit updates the detection to use `.fixed-modal` which will match both legacy and modern modals.
    @davidtaylorhq
    davidtaylorhq committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d23a695 View commit details
    Browse the repository at this point in the history