FIX: Ensure javascript caches are unique per theme #23126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbianca
approved these changes
Aug 17, 2023
app/models/javascript_cache.rb
Outdated
| @@ -47,7 +47,7 @@ def content_cannot_be_nil | |||
| # | |||
| # index_javascript_caches_on_digest (digest) | |||
| # index_javascript_caches_on_theme_field_id (theme_field_id) | |||
There was a problem hiding this comment.
Should this be an UNIQUE index too?
There was a problem hiding this comment.
I suppose I should do both.
| class EnsureJavascriptCacheIsUniquePerTheme < ActiveRecord::Migration[7.0] | ||
| def change | ||
| remove_index :javascript_caches, :theme_id | ||
| add_index :javascript_caches, :theme_id, unique: true |
There was a problem hiding this comment.
Is there any chance this could break an existing site because we have more than a cache for a theme?
There was a problem hiding this comment.
It's possible, so I ran a script to check that this hadn't happened
danielwaterworth
force-pushed
the
ensure-unique-js-cache
branch
from
b989074
to
df87d67
Compare
We were assuming that this was the case before, but not enforcing it.
danielwaterworth
force-pushed
the
ensure-unique-js-cache
branch
3 times, most recently
from
e23ef70
to
d3392d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming that this was the case before, but not enforcing it.