Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: update /new toggle styles, class names #23154

Merged
merged 2 commits into from Aug 21, 2023
Merged

UX: update /new toggle styles, class names #23154

merged 2 commits into from Aug 21, 2023

Conversation

awesomerobot
Copy link
Member

  • Minor style adjustments
  • Removes "all" count because it's redundant to the count on New
  • Updates generic class names with -- modifier to follow BEM and help avoid class name collisions
  • Hides the toggle when bulk select is enabled (the UI ends up being too busy)

Before:
Screenshot 2023-08-18 at 6 02 33 PM

After:
Screenshot 2023-08-18 at 5 51 20 PM

Before:
Screenshot 2023-08-18 at 6 03 23 PM

After:
Screenshot 2023-08-18 at 5 51 31 PM

@tgxworld tgxworld merged commit 2a49757 into main Aug 21, 2023
13 checks passed
@tgxworld tgxworld deleted the new-toggle-adju branch August 21, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZogStriP ZogStriP ZogStriP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@awesomerobot @ZogStriP @tgxworld