Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: update styling for related/suggested #23217

Merged
merged 2 commits into from Aug 24, 2023

Conversation

tytekkit
Copy link
Contributor

This PR fixes styling for previous related/suggested changes' positioning, specifically for topics, and updates the active icon color to stay easily visible by removing a line that changed its active color.

Topic (Before)
CleanShot 2023-08-24 at 00 18 04@2x

Topic (After)
CleanShot 2023-08-24 at 00 13 11@2x

Message (Unchanged)
CleanShot 2023-08-24 at 00 19 12@2x

This PR fixes styling for previous related/suggested changes' positioning being off for topics and updates the active icon color by removing a line that changed its active color.
padding: 0.75em 0.65em;
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector is later in group, because page specificity for .regular is needed to apply specific styling to topic view only.

@@ -16,9 +16,6 @@
}
&.active {
border-bottom: 2px solid var(--tertiary);
.d-icon {
color: var(--primary-low);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes icon color

@tytekkit tytekkit merged commit af34e91 into main Aug 24, 2023
13 checks passed
@tytekkit tytekkit deleted the ux-update-styling-related-and-suggested branch August 24, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants