UX: update styling for related/suggested #23231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses state issues for icons of the Related & Suggested buttons, as well as well as fixes alignment issues for folding phones / tablets, wider mobile devices by moving styling to the desktop scss file.
Link new desktop/scss
|
Will be re-opened after running some screen size tests |
Add breathing space on mobile.
tytekkit
commented
Aug 24, 2023
| } | ||
| } | ||
|
|
||
| @media screen and (min-width: 550px) { |
There was a problem hiding this comment.
removed media query -> desktop.scss
CvX
approved these changes
Aug 24, 2023
tytekkit
commented
Aug 24, 2023
| @@ -9,38 +9,23 @@ | |||
| .btn { | |||
| color: var(--primary); | |||
| background-color: transparent; | |||
| border-bottom: 2px solid transparent; | |||
There was a problem hiding this comment.
Removed borders in lieu of box-shadows
tytekkit
commented
Aug 24, 2023
| .more-topics__container { | ||
| .nav { | ||
| position: absolute; | ||
| top: 2px; |
There was a problem hiding this comment.
Needs offset without border
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the previous updated of related/suggested buttons and addresses a couple issues:
Wide Mobile:
Before
After -- based on mobile.scss instead of media query, absolute positioning is used in desktop.scss instead
Narrow Mobile:
Before
After
Button State Icons:
Before
After
![CleanShot 2023-08-24 at 13 40 30]