Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: support to initial values for form templates through /new-topic #23313

Merged
merged 6 commits into from Aug 29, 2023

Conversation

renato
Copy link
Contributor

@renato renato commented Aug 29, 2023

Adds support to setting initial values for the (experimental) form templates through /new-topic?fieldname=fieldvalue.

A new required id field was also added to the form template fields to support both this /new-topic approach without relying on the field Label as well as the future implementation of the JSON output that will be stored with the created topic.

Default max_form_template_content_length was bumped to 5k as the old default was not enough for our initially tested use cases.

@renato renato marked this pull request as draft August 29, 2023 14:59
@renato renato force-pushed the form_template_initial_values branch from 5bcea6c to 74c34c3 Compare August 29, 2023 18:48
@renato renato marked this pull request as ready for review August 29, 2023 19:02
Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work 🤩 Just one small comment to look at before merging 💬

lib/validators/form_template_yaml_validator.rb Outdated Show resolved Hide resolved
@renato renato merged commit 58b49bc into main Aug 29, 2023
13 checks passed
@renato renato deleted the form_template_initial_values branch August 29, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants