FIX: closes chat emoji picker on body scroll #23362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix we would scroll the emoji picker with the body of the page in drawer mode. With this fix scrolling inside the drawer or the emoji picker will be scroll the drawer or the emoji picker, but, scrolling body will close the chat emoji picker.
SamSaffron
reviewed
Sep 1, 2023
| @@ -15,6 +15,7 @@ | |||
| {{will-destroy (if @willDestroy @willDestroy (noop))}} | |||
| {{will-destroy this.removeClickOutsideEventListener}} | |||
| {{on "keydown" this.trapKeyDownEvents}} | |||
| ...attributes | |||
There was a problem hiding this comment.
is this left over debugging code or some sort of magic I never learned about?
There was a problem hiding this comment.
made a topic about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix we would scroll the emoji picker with the body of the page in drawer mode.
With this fix scrolling inside the drawer or the emoji picker will scroll the drawer or the emoji picker, but, scrolling body will close the chat emoji picker.