Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Everyone should be aware a cached summary is outdated. #23438

Merged
merged 1 commit into from
Sep 6, 2023
Merged

FIX: Everyone should be aware a cached summary is outdated. #23438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/services/topic_summarization.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ def summarize(topic, user, opts = {}, &on_partial_blk)

if use_cached?(existing_summary, can_summarize, current_topic_sha, !!opts[:skip_age_check])
# It's important that we signal a cached summary is outdated
if can_summarize && new_targets?(existing_summary, current_topic_sha)
existing_summary.mark_as_outdated
end
existing_summary.mark_as_outdated if new_targets?(existing_summary, current_topic_sha)

return existing_summary
end
Expand Down