A11Y: Improvements to <DToggleSwitch/> component
#23514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `gap` instead of `margin-right` allows there to only be a spacing when there is a label present, otherwise when the toggle is used without a label, there shouldn't be any spacing on the right.
The tertiary color on the checked toggle can be hard to see, so the added offset will make it clear that the element is focused.
Since the toggle switch element is a `<button>` not an `<input>`, we should be using `aria-pressed` instead of `aria-checked`
`aria-checked` can be used instead of `aria-pressed` due to `role="switch"` attribute on the button which treats the `<button>` like a checkbox
renato
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various improvements to the
<DToggleSwitch/>component:.gjsfile.gapproperty to control spacing between the toggle switch and its label. This is better than amargin-rightbecause the gap will only be present if the label is also present, and therefore prevents a trailing margin for switches without labelsprefers-reduced-motion, slider of the toggle will switch without a transitionPreview:
Screen.Recording.2023-09-11.at.10.47.13.mov