DEV: Refactor webauthn to support passkeys (1/3) #23586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part 1 of 3, split up of PR #23529. This PR refactors the webauthn code to support passkey authentication/registration. Passkeys aren't used yet, that is coming in PRs 2 and 3.
pmusaraj
commented
Sep 14, 2023
| # bit 6 - attested credential data | ||
| # bit 7 - extension data | ||
|
|
||
| def validate_user_presence |
There was a problem hiding this comment.
Previously, we were checking for the user presence flag only but the validation was using the wrong name. The change here adds the correct error message for user presence and adds the correct flow for user verification. (Note that in the registration/authentication services, verification is only used for first-factor keys.)
This was referenced Sep 14, 2023
pmusaraj
changed the title
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/support-for-apples-passkeys-system/229259/32 |
|
Marked this as ready for review just now, if you have a chance to review please @tgxworld @davidtaylorhq. |
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 27, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
tgxworld
reviewed
Sep 28, 2023
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
tgxworld
reviewed
Sep 29, 2023
tgxworld
reviewed
Sep 29, 2023
tgxworld
approved these changes
Sep 29, 2023
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of 3, split up of PR #23529. This PR refactors the webauthn code to support passkey authentication/registration.
Passkeys aren't used yet, that is coming in PRs 2 and 3.
Changes in this PR include:
rp_idandoriginproperties (this also simplifies local testing)