Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Add failing test for pull-hotlinked codeblocks #23682

Merged
merged 1 commit into from Sep 29, 2023

Conversation

davidtaylorhq
Copy link
Member

If a codeblock contains exactly the same markdown as an image which has been retrieved by the 'pull hotlinked' job, then it will be replaced with the new URL. This commit adds failing (skipped) tests for this issue.

If a codeblock contains **exactly** the same markdown as an image which has been retrieved by the 'pull hotlinked' job, then it will be replaced with the new URL. This commit adds failing (skipped) tests for this issue.
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/code-block-image-link-gets-modified-when-hotlinked-image-is-downloaded/271571/7

@davidtaylorhq davidtaylorhq merged commit 48e3d5b into main Sep 29, 2023
16 of 17 checks passed
@davidtaylorhq davidtaylorhq deleted the inline-uploads-duplicate branch September 29, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants