FIX: do not serialize status when profile is hidden #23946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
approved these changes
Oct 16, 2023
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
|
thanks @pmusaraj |
AndrewPrigorshnev
added a commit
that referenced
this pull request
Feb 26, 2024
…ence (#24300) Users can hide their public profile and presence information by checking “Hide my public profile and presence features” on the `u/{username}/preferences/interface` page. In that case, we also don't want to return user status from the server. This work has been started in #23946. The current PR fixes all the remaining places in Core. Note that the actual fix is quite simple – a5802f4. But we had a fair amount of duplication in the code responsible for the user status serialization, so I had to dry that up first. The refactoring as well as adding some additional tests is the main part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can decide to hide their profile and presence. It seems more correct to also not return the status in this case.