UX: Minor fixes to passkey handling #23947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmusaraj
commented
Oct 16, 2023
•
pmusaraj
commented
- don't try to guess the name of the manager (too many options)
- improve error message when registration is not allowed
- output error in console when registration fails
- minor fix to rename dialog layout
- hides action buttons in DiscourseHub (because adding passkeys there is not possible)
- adds acceptance test to ensure action buttons are hidden for admins seeing another user's profile
- don't try to guess the name of the manager (too many options) - improve error message when registration is not allowed - output error in console when registration fails
renato
approved these changes
Oct 17, 2023
renato
reviewed
Oct 17, 2023
| @@ -111,6 +102,8 @@ export default class UserPasskeys extends Component { | |||
| bodyComponentModel: registrationResponse, | |||
| }); | |||
| } catch (error) { | |||
| // eslint-disable-next-line no-console | |||
| console.error(error); | |||
There was a problem hiding this comment.
Leftover or (considering the eslint-disable...) intentional?
There was a problem hiding this comment.
Thanks, it's intentional. In this particular case, it's good to output the error in the console, it can help debug issues with a particular credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.