FIX: Use the category logo matching the theme #24033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug in which the dark category logo would be used in a light theme if the system preferences were set to dark and the user forced the use of a light theme in Discourse
megothss
commented
Oct 20, 2023
| import CdnImg from "discourse/components/cdn-img"; | ||
| import { getURLWithCDN } from "discourse-common/lib/get-url"; | ||
|
|
||
| export default class LightDarkImg extends Component { |
There was a problem hiding this comment.
I created this component because this pair of light/dark images can be used in the future in other places.
I'm just not sure about the name, I couldn't think of anything better.
There was a problem hiding this comment.
I can't think of a better name, either.
ZogStriP
reviewed
Oct 20, 2023
| <template> | ||
| {{#if this.isDarkImageAvailable}} | ||
| <picture> | ||
| <source |
There was a problem hiding this comment.
Any reasons we can't use the <CdnImg component here instead of relying on darkImgCndSrc? 🤔
There was a problem hiding this comment.
Because we're using it in a <source> tag. <CdnImg> is an <img>
ZogStriP
approved these changes
Oct 20, 2023
pmusaraj
approved these changes
Oct 20, 2023
| import CdnImg from "discourse/components/cdn-img"; | ||
| import { getURLWithCDN } from "discourse-common/lib/get-url"; | ||
|
|
||
| export default class LightDarkImg extends Component { |
There was a problem hiding this comment.
I can't think of a better name, either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in which the dark category logo would be used in a light theme if the system preference was set to dark and the user forced the use of a light theme in Discourse