FIX: ensures users can open channel invites #24067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were incorrectly generating URLs with message id even when it was not provider resulting in a route ending with "undefined", which was causing an error. This commit also uses this opportunity to: - move `invite_users` into a proper controller inside the API namespace - refactors the code into a service: `Chat::InviteUsersToChannel`
jjaffeux
commented
Oct 24, 2023
plugins/chat/assets/javascripts/discourse/initializers/chat-user-menu.js
Outdated
Show resolved
Hide resolved
jjaffeux
commented
Oct 24, 2023
plugins/chat/assets/javascripts/discourse/widgets/chat-invitation-notification-item.js
Show resolved
Hide resolved
jjaffeux
commented
Oct 24, 2023
jjaffeux
commented
Oct 24, 2023
jjaffeux
commented
Oct 24, 2023
jjaffeux
commented
Oct 24, 2023
dbattersby
reviewed
Oct 24, 2023
plugins/chat/assets/javascripts/discourse/initializers/chat-user-menu.js
Outdated
Show resolved
Hide resolved
dbattersby
reviewed
Oct 24, 2023
dbattersby
reviewed
Oct 24, 2023
dbattersby
reviewed
Oct 24, 2023
plugins/chat/spec/services/chat/invite_users_to_channel_spec.rb
Outdated
Show resolved
Hide resolved
dbattersby
reviewed
Oct 24, 2023
|
Nice work, some small comments but overall looks great 👍 |
dbattersby
approved these changes
Oct 24, 2023
CvX
reviewed
Oct 24, 2023
plugins/chat/app/controllers/chat/api/channels_invites_controller.rb
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly generating URLs with message id even when it was not provided, resulting in a route ending with "undefined", which was causing an error.
This commit also uses this opportunity to:
invite_usersinto a proper controller inside the API namespaceChat::InviteUsersToChannel