DEV: Change anonymous_posting_min_trust_level to a group-based setting #24072
+223
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
force-pushed
the
dev/rename-tl-group-settings-1
branch
2 times, most recently
from
e2e6dc3
to
a9ca5a1
Compare
No plugins or themes rely on anonymous_posting_min_trust_level so we can just switch straight over to anonymous_posting_allowed_groups
martin-brennan
force-pushed
the
dev/rename-tl-group-settings-1
branch
from
a9ca5a1
to
720368e
Compare
tgxworld
reviewed
Oct 24, 2023
app/assets/javascripts/discourse-common/addon/lib/auto-groups.js
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Oct 24, 2023
app/assets/javascripts/discourse/app/components/user-menu/profile-tab-content.js
Outdated
Show resolved
Hide resolved
martin-brennan
force-pushed
the
dev/rename-tl-group-settings-1
branch
from
1219971
to
807af5a
Compare
|
@tgxworld ready for another round please |
tgxworld
reviewed
Oct 25, 2023
| result.merge( | ||
| group_name => { | ||
| id: group_id, | ||
| automatic: true, |
There was a problem hiding this comment.
Small one but I wonder about the value of including this attribute considering that it will always be true and the constant name reflects that all groups are automatic.
There was a problem hiding this comment.
It's just because these will be used in tests to simulate actual groups on the user model, and this is how they are represented, since they can be mixed in with non-automatic groups.
tgxworld
approved these changes
Oct 25, 2023
|
Changes look good to me 👍 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/trust-level-permissions-table-inc-moderator-roles/224824/57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No plugins or themes rely on anonymous_posting_min_trust_level so we
can just switch straight over to anonymous_posting_allowed_groups
This also adds an
AUTO_GROUPSconst which can be imported in JStests which is analogous to the one defined in
group.rb. This can be usedto set the current user's groups where JS tests call for checking these groups
against site settings.
Finally a
AtLeastOneGroupValidatorvalidator is added forgroup_listsitesettings which ensures that at least one group is always selected, since if
you want to allow all users to use a feature in this way you can just use
the
everyonegroup.