Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: fix minor chat transcript overflow #24158

Merged
merged 1 commit into from Oct 30, 2023
Merged

Conversation

awesomerobot
Copy link
Member

The padding on this container can cause overflow in some cases (note the l being cropped here):

Before:

Screenshot 2023-10-30 at 1 42 21 PM

After:
Screenshot 2023-10-30 at 1 46 58 PM

(border-box means the padding is taken into consideration for width calculations, vs the default content-box which ignores padding)

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Oct 30, 2023
@davidtaylorhq
Copy link
Member

davidtaylorhq commented Oct 30, 2023

(For the record: I'd like to say that I did not write the quote in the screenshot 🤣 )

@awesomerobot
Copy link
Member Author

😆 sorry @davidtaylorhq not sure why I used Allen Ginsburg placeholder today

@awesomerobot awesomerobot merged commit 5e63370 into main Oct 30, 2023
14 checks passed
@awesomerobot awesomerobot deleted the chat-transcript-overflow branch October 30, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat PRs which include a change to Chat plugin
3 participants