FIX: Maintain destination_url after passkey login #24171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to regular login and SSO login, when logging in via passkey we need to respect the destination_url cookie. This fixes an issue with the iOS app where the redirect to the app authorization screen was not working after logging in via passkey.
pmusaraj
changed the title
CvX
approved these changes
Oct 31, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/passkey-on-discoursehub-ios-ipados-works-funny/283759/4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to regular login and SSO login, when logging in via passkey we
need to respect the
destination_urlcookie. This fixes an issue withthe iOS app where the redirect to the app authorization screen was not
working after logging in via passkey.