New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: chat redesign - back button to exit threads #24189
Conversation
plugins/chat/assets/javascripts/discourse/components/chat-drawer/header/title.gjs
Outdated
Show resolved
Hide resolved
{{icon @icon}} | ||
{{/if}} | ||
|
||
{{this.headerTitle}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally I would prefer to avoid any text without any direct wrapper, here you have
div
icon span
text
- text
I would recommend having two last text wrapped inside a span
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've added wrapper for all of this info inside the chat drawer title so can easily style them or check existence in tests if needed.
plugins/chat/assets/javascripts/discourse/components/chat/thread-list/header.gjs
Show resolved
Hide resolved
plugins/chat/assets/javascripts/discourse/components/chat/thread/header.gjs
Outdated
Show resolved
Hide resolved
plugins/chat/assets/stylesheets/common/chat-thread-list-header.scss
Outdated
Show resolved
Hide resolved
@dbattersby I fixed various linting and js errors, I suspect your editor is misconfigured for gjs, let me know if you need help. Other than this, It's nice if you can fix the few remaining comments, but already ok to merge like this. |
👋🏼 just noticed this pull request! I opened #24260 today, but because the process is mostly automated, I could put that on hold and re-run it again after this has landed, if that makes things easier in. In the meantime, if you noticed anything that doesn't seem right in the conversation, feel free to let me know on there. |
Thanks, david warned me about the migration you are doing. We will merge this very soon. |
This is part of the chat redesign work to improve chat navigation.
This change includes:
gjs
format./t/-/112524