FIX: add dominant color attribute to chat image uploads #24214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbattersby
commented
Nov 2, 2023
| @@ -54,7 +54,10 @@ export async function processHTML({ container, selector, clickTarget }) { | |||
| .querySelector(SELECTORS.FILE_DETAILS_CONTAINER) | |||
| ?.innerText.trim() || null; | |||
|
|
|||
| const _dominantColor = innerImage.dataset?.dominantColor || null; | |||
| const _dominantColor = | |||
| item.dataset?.dominantColor ?? | |||
There was a problem hiding this comment.
In chat we don't have a wrapper for the image so the attribute is directly on the target image.
davidtaylorhq
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading images, they are assigned a dominant color which gets used in various places, such as Discourse Hub and the new lightbox. Previously in chat we didn't assign this attribute, so it was defaulting to a null value. We did however use it as an inline CSS style for the image background (which is visible while the image is downloaded).
This change adds
data-dominant-colorto the uploaded image in chat and uses it correctly within lightbox.