Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: show lightbox carousel by default if post has 2 or more images #24216

Merged
merged 3 commits into from Nov 3, 2023
Merged

FEATURE: show lightbox carousel by default if post has 2 or more images #24216

merged 3 commits into from Nov 3, 2023

Conversation

dbattersby
Copy link
Contributor

@dbattersby dbattersby commented Nov 2, 2023 •
edited

This work includes the following updates for the new lightbox:

  • Show carousel by default if there are more than 1 image in a post
  • Removes toggling of carousel on mobile - now always open if there are more than 1 image
  • Updates swipe down gesture on mobile to close lightbox (previously used to toggle carousel)
  • Removes swipe up gesture on mobile (was previously used to close lightbox)

The tests are updated to handle these changes in swipe direction and allow for the carousel being open by default.

@dbattersby dbattersby marked this pull request as ready for review November 3, 2023 03:44
@dbattersby
Copy link
Contributor Author

Thank you @jjaffeux 👍

@dbattersby dbattersby merged commit bb7a450 into main Nov 3, 2023
14 checks passed
@dbattersby dbattersby deleted the show-lightbox-carousel-by-default branch November 3, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@dbattersby @jjaffeux