Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Port discourse-table-builder theme component to core #24441

Merged
merged 12 commits into from Nov 30, 2023

Conversation

keegangeorge
Copy link
Member

@keegangeorge keegangeorge commented Nov 17, 2023

This PR is to port disourse-table-builder theme component to core.

Specifically:

  • it adds SpreadsheetEditor component to core (converted to .gjs)
  • updates post-decroations.js to include table edit functionality in addition to fullscreen table
  • adds table builder related utilities (arrayToTable(), findTableRegex(), tokenRange()) to lib/utilities.js
  • updates composer popup menu to add ability to insert tables
  • adds acceptance/unit tests and system specs for table bulding/editing
  • adds table builder related scss files
  • adds new JS scripts jspreadsheet and jsuites for usage in SpreadsheetEditor component
  • adds an updated bash script for updating table builder dependencies easily

@keegangeorge keegangeorge changed the title DEV: Initial spreadsheet functionality DEV: Port discourse-table-builder theme component to core Nov 17, 2023
@keegangeorge keegangeorge marked this pull request as ready for review November 21, 2023 00:58
@keegangeorge keegangeorge merged commit d2b53cc into main Nov 30, 2023
19 checks passed
@keegangeorge keegangeorge deleted the port-table-builder branch November 30, 2023 18:54
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/table-builder/236016/118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants