New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: remove trailing slashes and query params on meta-tag-updater's canonical url #24445
Conversation
The test failures The simplest fix is just adding these leading slashes in the few places they're missing, which I think is expected. The alternative is handling this exception before calling We also have a condition on
|
Omitting `/` prefix was incorrect and could break in the future (see: discourse/discourse#24445)
Omitting `/` prefix was incorrect and could break in the future (see: discourse/discourse#24445)
I submitted two PRs to plugins (see the linkbacks above) and there are two more instances of this in a single test file in core. Just go ahead and fix them here. No need to support incorrect paths 😃 |
Omitting `/` prefix was incorrect and could break in the future (see: discourse/discourse#24445)
This uses the same strategy from the server-side canonical URL generation to avoid inconsistencies.