FIX: plugin:install_all_gems Rake task not installing plugin gem
#24522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change? This regressed in dec68d7 where the commit assumes that plugin gems are always installed when the `plugin:install_all_gems` Rake task is ran as it would run the our Rails initializers which activates plugins and install the gems. However, this assumption only holds true when the `LOAD_PLUGINS` is present and set to `1`. What does this change do? This commit changes the `plugin:install_all_gems` to load the Rails environment with `LOAD_PLUGINS` set to `1` such that the plugin gems will be installed as part of our initialization process for the app. The commit also removes the `plugin:install_gems` Rake task which is currently a noop and does not seem to be used anywhere..
martin-brennan
approved these changes
Nov 23, 2023
tgxworld
added a commit
to tgxworld/discourse
that referenced
this pull request
Nov 23, 2023
…n gem (discourse#24522)" This breaks the `plugin:install_all_gems` Rake task when used before Redis is running. Need to go back to the drawing board. This reverts commit 189aa5f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
This regressed in dec68d7 where the
commit assumes that plugin gems are always installed when the
plugin:install_all_gemsRake task is ran as it would run the our Railsinitializers which activates plugins and install the gems. However, this
assumption only holds true when the
LOAD_PLUGINSenv variable is present and set to1.What does this change do?
This commit changes the
plugin:install_all_gemsto load the Railsenvironment with the
LOAD_PLUGINSenv variable set to1such that the plugin gemswill be installed as part of our initialization process for the app.
The commit also removes the
plugin:install_gemsRake task which iscurrently a noop and does not seem to be used anywhere.