FIX: Standardize names for category variables #24527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
reviewed
Nov 23, 2023
app/assets/javascripts/discourse/app/components/bread-crumbs.hbs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/helpers/category-variables.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/acceptance/category-new-test.js
Outdated
Show resolved
Hide resolved
nbianca
force-pushed
the
fix_category_vars
branch
from
9a27a84
to
b863eb5
Compare
--category-bg-color and --category-badge-color were both used to represent category.color. --category-badge-color is now used instead for all of them.
nbianca
force-pushed
the
fix_category_vars
branch
from
b863eb5
to
6396afa
Compare
CvX
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--category-bg-color and --category-badge-color were both used to
represent category.color. --category-badge-color is now used instead for
all of them.