FIX: Serialize parent categories first #24530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent category is necessary for the client to build the category-link (for example, the color of the parent category is needed for rendering the category badge). If the parent category is serialized after the child category, the client will not build the parent-child relationship correctly.
nbianca
force-pushed
the
fix_topic_list-serialization
branch
from
3ae3b0b
to
9d47271
Compare
jjaffeux
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent category is necessary for the client to build the category-link (for example, the color of the parent category is needed for rendering the category badge). If the parent category is serialized after the child category, the client will not build the parent-child relationship correctly.