FIX: Add setters for some group properties #24572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These properties are set on the "Manage > Categories" group page. It used to work, but only because it overridden the properties and it did not update the IDs too.
|
Given that we are fixing something here and the broken behaviour went unnoticed. Is there a test we should add here to prevent this from regressing? |
|
The bug is not visible right now (only a warning in the console), but it would be with the following category-scaling PRs. |
davidtaylorhq
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are set on the "Manage > Categories" group page. It used to work, but only because it overridden the properties and it did not update the IDs too.