FIX: Don't refresh on topic search result click #24697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where when selecting a topic search result we were refreshing the page rather than letting
DiscourseURL
redirect us to the given topic. This was because we were leaning on aa
tag and it's href to handle the redirectdiscourse/app/assets/javascripts/discourse/app/components/search-menu/results/types.hbs
Lines 15 to 16 in 3aeff56
rather than
preventDefault
'ing the redirect