FIX: correctly update replies_count on chat_threads #24711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-brennan I pinged you because you wrote this and I wanted your opinion. |
The previous query would look at the existing messages, count them, and update the associated thread. But, if for some reason messages were **ALL** deleted without updating the `replies_count`, then the query wouldn't find any message, and wouldn't update any thread's `replies_count`.
jjaffeux
force-pushed
the
chat/replies-count-update
branch
from
9078822
to
0f3deee
Compare
AndrewPrigorshnev
approved these changes
Dec 5, 2023
| RETURNING ct.id AS thread_id | ||
| ) | ||
| SELECT thread_id | ||
| FROM updated_threads; |
There was a problem hiding this comment.
I believe, we don't need WITH here, the inner UPDATE query produces the same output, so it can be just:
UPDATE chat_threads ct
SET replies_count = COALESCE(subquery.new_count, 0)
FROM (
SELECT cm.thread_id, COUNT(cm.*) - 1 AS new_count
FROM chat_threads
LEFT JOIN chat_messages cm ON cm.thread_id = chat_threads.id AND cm.deleted_at IS NULL
GROUP BY cm.thread_id
) AS subquery
WHERE ct.id = subquery.thread_id AND ct.replies_count IS DISTINCT FROM COALESCE(subquery.new_count, 0)
RETURNING ct.id AS thread_idThere was a problem hiding this comment.
Yes I think you are correct
|
Change looks good, ty for pinging me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous query would look at the existing messages, count them, and update the associated thread.
But, if for some reason messages were ALL deleted without updating the
replies_count, then the query wouldn't find any message, and wouldn't update any thread'sreplies_count.