Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Allow quoting thread's original message #24773

Merged
merged 2 commits into from Dec 11, 2023
Merged

FIX: Allow quoting thread's original message #24773

merged 2 commits into from Dec 11, 2023

Conversation

jancernik
Copy link
Member

This change makes it so the transcribed message only shows as a thread if the message has nested messages, even if the message has a threadId. This allows for quoting thread messages, since currently, when quoting a thread in a post, only the original message is shown.

[chat quote="jan2;274;2023-12-06T04:07:04Z" channelId="2" threadId="140" threadTitle="Thread"]
original message content
[/chat]

Before

2023-12-07_12-09

After

2023-12-07_12-08

@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Dec 7, 2023
@jjaffeux
Copy link
Contributor

jjaffeux commented Dec 7, 2023

Can you write specs for this?
You can take example on spec/lib/pretty_text_spec.rb and create our own for chat

jjaffeux
jjaffeux approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jjaffeux jjaffeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 🚀

@jjaffeux
Copy link
Contributor

Merge when you want, great 👍

@jancernik jancernik merged commit 7287229 into discourse:main Dec 11, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaffeux jjaffeux jjaffeux approved these changes

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
2 participants
@jancernik @jjaffeux