Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Chat info area back button + styling tweaks #24966

Merged
merged 3 commits into from Dec 19, 2023
Merged

UX: Chat info area back button + styling tweaks #24966

merged 3 commits into from Dec 19, 2023

Conversation

chapoi
Copy link
Contributor

@chapoi chapoi commented Dec 19, 2023

Back button to navigate out of add-member area

Currently on mobile, once you're in the member area, there is no easy to return to the general settings area, except exiting the settings altogether, which isn't very userfriendly. A go-back link solves the problem.

image

A better solution would be to customise the header to show a different title and navigate via there, but that's more complex, so this is the quick-nd-easy solution.

Styling tweaks

  • Removed the background from the leave button
image
  • Added more spacing between the sections on desktop and removed the fixed height for rows
image

@chapoi chapoi requested a review from jjaffeux December 19, 2023 11:56
Copy link
Contributor

@jjaffeux jjaffeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I just added a spec.

@jjaffeux jjaffeux merged commit 70f0cb6 into main Dec 19, 2023
18 of 19 checks passed
@jjaffeux jjaffeux deleted the chat-info-area branch December 19, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants