FIX: Update position on model when re-positioning record #24997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Dec 21, 2023
| @@ -33,5 +33,7 @@ def move_to(position_arg) | |||
| WHERE id = :id", | |||
| id: id, | |||
| position: position | |||
|
|
|||
| self.position = position | |||
There was a problem hiding this comment.
This is the relevant change right here.
Drenmi
commented
Dec 21, 2023
Comment on lines
+199
to
+200
| category_params[:email_in] = nil if category_params[:email_in].blank? | ||
| category_params[:minimum_required_tags] = 0 if category_params[:minimum_required_tags].blank? |
There was a problem hiding this comment.
Adjacent code cleanup. No need to use lonely operator when calling #blank? since it's defined one nil as well.
There was a problem hiding this comment.
Yeah this is a weird oversight...also never heard this called the "lonely operator" 馃槅
martin-brennan
approved these changes
Dec 21, 2023
Comment on lines
+199
to
+200
| category_params[:email_in] = nil if category_params[:email_in].blank? | ||
| category_params[:minimum_required_tags] = 0 if category_params[:minimum_required_tags].blank? |
There was a problem hiding this comment.
Yeah this is a weird oversight...also never heard this called the "lonely operator" 馃槅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is happening?
When updating the position of a category, the server correctly updates the position in the database, but the response sent back to the client still contains the old position, causing it to "flip back" in the UI when saving. Only reloading the page will reveal the new, correct value.
Why is it happening?
The
Positionableconcern correctly positions the record and updates the database, but we don't assign the new position to the already instantiated model.How does this fix it?
EZPZ, just assign
self.positionafter the database update. 馃槑