Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL support. #2525

Merged
merged 1 commit into from Jul 10, 2014
Merged

Add RTL support. #2525

merged 1 commit into from Jul 10, 2014

Conversation

eyalev
Copy link
Contributor

@eyalev eyalev commented Jul 10, 2014

@discoursebot
Copy link

You've signed the CLA, eyalev. Thank you! This pull request is ready for review.

@ZogStriP
Copy link
Member

Since this is UI-related, would you mind posting a couple of screenshots?

nlalonde
nlalonde reviewed Jul 10, 2014
View reviewed changes
app/helpers/application_helper.rb
@@ -124,6 +124,10 @@ def mobile_device?
MobileDetection.mobile_device?(request.user_agent)
end

def rtl_view?
current_user.try(:locale).in? %w(he ar)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work if allow_user_locale is enabled. It should look at SiteSetting.default_locale too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@eyalev
Copy link
Contributor Author

eyalev commented Jul 10, 2014

Hebrew locale screenshot:

hebrew_locale

@nlalonde
Copy link
Member

👍 Thanks!

nlalonde added a commit that referenced this pull request Jul 10, 2014
@nlalonde
Merge pull request #2525 from eyalev/rtl-support
09959d3 
Add RTL support.
@nlalonde nlalonde merged commit 09959d3 into discourse:master Jul 10, 2014
@eyalev eyalev deleted the rtl-support branch July 11, 2014 20:48
@perpi
Copy link

perpi commented Jul 13, 2014

How it works?
I've updated this files:

app/assets/stylesheets/common/base/rtl.scss
app/helpers/application_helper.rb

But, nothing happened!
May you add an instruction here: https://meta.discourse.org/t/css-customisation-for-rtl/10614/19

@eyalev
Copy link
Contributor Author

eyalev commented Jul 13, 2014

Update to the latest Discourse version and choose an RTL language (currently only 'he' and 'ar' are defined as RTL).
Which language you're using?

@SamSaffron
Copy link
Member

you need to get started translating it :)

On Mon, Jul 14, 2014 at 3:04 PM, diff- notifications@github.com wrote:

Where's Arabic?!

—
Reply to this email directly or view it on GitHub
#2525 (comment).

@perpi
Copy link

perpi commented Jul 14, 2014

Then pull request for it here?
ok.

@eyalev
Copy link
Contributor Author

eyalev commented Jul 15, 2014

Check this howto: https://meta.discourse.org/t/contribute-a-translation-to-discourse/14882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@eyalev @discoursebot @ZogStriP @nlalonde @perpi @SamSaffron