PERF: Add cache for Category.asyncFindByIds #25531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janzenisaac
approved these changes
Feb 2, 2024
nbianca
approved these changes
Feb 2, 2024
app/assets/javascripts/discourse-common/addon/utils/multi-cache.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse-common/addon/utils/multi-cache.js
Outdated
Show resolved
Hide resolved
danielwaterworth
force-pushed
the
category-cache
branch
from
d16a855
to
c608285
Compare
This way, we don't fetch the same category multiple times.
danielwaterworth
force-pushed
the
category-cache
branch
from
c608285
to
8e347be
Compare
…e.js Co-authored-by: Bianca Nenciu <nbianca@users.noreply.github.com>
renato
pushed a commit
to renato/discourse
that referenced
this pull request
Feb 29, 2024
This way, we don't fetch the same category multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we don't fetch the same category multiple times.