FIX: Update themes javascript cache after running themes migrations #25562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this change? This is caused by a regression in 59839e4, where we stopped saving the `Theme` object because it was unnecessary. However, it resulted in the `after_save` callback not being called and hence `Theme#update_javascript_cache!` not being called. As a result, some sites were reporting that after runing a theme migration, the defaults for the theme settings were used instead of the settings overrides stored in the database. What does this change do? Add a call to `Theme#update_javascript_cache!` after running theme migrations.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/why-are-custom-header-links-overridden/293359/11 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/footer-text-doesnt-populate-after-recent-update/293906/3 |
renato
pushed a commit
to renato/discourse
that referenced
this pull request
Feb 29, 2024
…iscourse#25562) Why this change? This is caused by a regression in 59839e4, where we stopped saving the `Theme` object because it was unnecessary. However, it resulted in the `after_save` callback not being called and hence `Theme#update_javascript_cache!` not being called. As a result, some sites were reporting that after runing a theme migration, the defaults for the theme settings were used instead of the settings overrides stored in the database. What does this change do? Add a call to `Theme#update_javascript_cache!` after running theme migrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
This is caused by a regression in
59839e4, where we stopped saving the
Themeobject because it was unnecessary. However, it resulted in theafter_savecallback not being called and henceTheme#update_javascript_cache!not being called. As a result, somesites were reporting that after runing a theme migration, the defaults
for the theme settings were used instead of the settings overrides
stored in the database.
What does this change do?
Add a call to
Theme#update_javascript_cache!after running thememigrations.