FIX: Allow several chat channels to have an empty slug #25680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPrigorshnev
changed the title
AndrewPrigorshnev
changed the title
AndrewPrigorshnev
force-pushed
the
fix/error-when-creating-a-chat-channel-with-a-unicode-name
branch
2 times, most recently
from
5e6c302
to
b16166a
Compare
AndrewPrigorshnev
force-pushed
the
fix/error-when-creating-a-chat-channel-with-a-unicode-name
branch
from
b16166a
to
a5380e6
Compare
|
Nice catch |
jjaffeux
approved these changes
Feb 14, 2024
AndrewPrigorshnev
deleted the
fix/error-when-creating-a-chat-channel-with-a-unicode-name
branch
renato
pushed a commit
to renato/discourse
that referenced
this pull request
Feb 29, 2024
In certain cases, chat channels may have empty slugs, it happens when: 1. The `slug_generation_method` setting is set to `None` 2. `slug_generation_method` is set to `ASCII` and a channel with a Unicode name and an empty slug is created (in this case, the code that creates channels tries to generate a slug and fallbacks to an empty slug) At the moment, we have a unique index on the `chat_channels.slug` column which leads to errors when creating several channels with empty slugs (Discourse is able to create one such channel, but when trying to create the second one fails because of the unique constraint). This PR fixes that by adding a `where` condition to the index. Slugs still have to be unique, but now many channels may have empty slugs. This fix is similar to the one we made to the category slugs – discourse@7ba914f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, chat channels may have empty slugs, it happens when:
slug_generation_methodsetting is set toNoneslug_generation_methodis set toASCIIand a channel with a Unicode name and an empty slug is created (in this case, the code that creates channels tries to generate a slug and fallbacks to an empty slug)At the moment, we have a unique index on the
chat_channels.slugcolumn which leads to errors when creating several channels with empty slugs (Discourse is able to create one such channel, but when trying to create the second one fails because of the unique constraint). This PR fixes that by adding awherecondition to the index. Slugs still have to be unique, but now many channels may have empty slugs.This fix is similar to the one we've made to the category slugs – 7ba914f.