FEATURE: Back button for schema theme settings #25743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
i18n
OsamaSayegh
force-pushed
the
feature/back-button-schema-theme-setting
branch
2 times, most recently
from
19df465
to
1a09ec5
Compare
OsamaSayegh
force-pushed
the
feature/back-button-schema-theme-setting
branch
from
1a09ec5
to
4a7684c
Compare
CvX
reviewed
Feb 19, 2024
| @@ -25,17 +27,16 @@ class Tree { | |||
| @tagName("") | |||
There was a problem hiding this comment.
Could you remove this while here? 🙂 (it's a no-op, that only applies to non-glimmer components)
| @@ -25,17 +27,16 @@ class Tree { | |||
| @tagName("") | |||
| export default class AdminThemeSettingSchema extends Component { | |||
| @tracked activeIndex = 0; | |||
| @tracked backButtonText = null; | |||
There was a problem hiding this comment.
There's no need to initialize null fields
Suggested change
| @tracked backButtonText = null; | |
| @tracked backButtonText; |
| assert.equal(tree.length, 2); | ||
| assert.true(tree[0].active, "the first node is active"); | ||
| assert.false(tree[1].active, "other nodes are not active"); | ||
| assert.equal(tree.nodes.length, 2); |
There was a problem hiding this comment.
We don't lint against it yet, but assert.strictEqual() is preferred over assert.equal()
tgxworld
approved these changes
Feb 20, 2024
renato
pushed a commit
to renato/discourse
that referenced
this pull request
Feb 29, 2024
Continue from discourse#25673. This commit adds a back button to the navigation tree of the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue from #25673.
This PR adds a back button to the navigation tree of the schema.