Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: muted tags breaking hot page when filtered to tags #25824

Merged
merged 7 commits into from Feb 23, 2024
Merged

FIX: muted tags breaking hot page when filtered to tags #25824

merged 7 commits into from Feb 23, 2024

Conversation

SamSaffron
Copy link
Member

Also, remove experimental setting and simply use top_menu for feature detection

@SamSaffron
FIX: muted tags breaking hot page when filtered to tags
efe7093 
Also, remove experimental setting and simply use top_menu for feature detection
@SamSaffron
Fix broken spec
b52d934 
code remains a tiny bit side effecty, but overall this is far easier to reason about
@SamSaffron
unconditionally fill up hot every 6 hours
5084b5f 
This means that when people eventually enable the hot top menu, there will
be topics in it
tgxworld
tgxworld reviewed Feb 23, 2024
View reviewed changes
app/models/user_option.rb Outdated Show resolved Hide resolved
SamSaffron and others added 3 commits February 23, 2024 16:46
@SamSaffron @tgxworld
Update app/models/user_option.rb
b3dfe1b 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
@SamSaffron @tgxworld
Update spec/jobs/update_topic_hot_scores_spec.rb
1c56296 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
@SamSaffron @tgxworld
Update spec/jobs/update_topic_hot_scores_spec.rb
db367f7 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
tgxworld
tgxworld approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍 I do think it'll be better to ship the change to lib/topic_query.rb in another commit or PR. This will make it easier to revert if it breaks something unexpected.

@SamSaffron
Copy link
Member Author

I hear you, I am ok to have all of this reverted if we need to. agree there is some risk here but that code was a big problem.

@SamSaffron SamSaffron merged commit 207cb20 into main Feb 23, 2024
19 checks passed
@SamSaffron SamSaffron deleted the hot-fixes branch February 23, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgxworld tgxworld tgxworld approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@SamSaffron @tgxworld