FEATURE: filter admin sidebar #25853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to filter admin sidebar. Filter can be cleared. In addition, it can be accessed with ctrl+/ shortcut
github-actions
bot
added
the
i18n
There was a problem hiding this comment.
Working nicely, just needs a few tweaks. Very happy with the speed of filtering! Visual bug, the X goes off to the side:
I think also when you click the X we should just re-focus the search box.
On mobile, we need to align the search better:
Maybe we will not even show this on mobile...not sure yet but at the least it needs alignment.
app/assets/javascripts/discourse/app/components/sidebar/filter.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/filter.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/filter.gjs
Outdated
Show resolved
Hide resolved
| {{#if this.shouldDisplay}} |
There was a problem hiding this comment.
It's super fast ATM doing this, so it's not necessary, but have you tried adding a css class that does display:none instead of adding/removing elements as David suggested? Just curious.
There was a problem hiding this comment.
No, once it became fast enough, I stopped improving
app/assets/javascripts/discourse/app/components/sidebar/api-section.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/api-section.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/api-section.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/filter-no-results.gjs
Show resolved
Hide resolved
app/assets/javascripts/discourse/app/components/sidebar/filter.gjs
Outdated
Show resolved
Hide resolved
…ction.js Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to filter admin sidebar.
The filter can be cleared. In addition, it can be accessed with ctrl+/ shortcut
Desktop demo
https://github.com/discourse/discourse/assets/72780/e3f2d22f-fff0-4770-aefc-00348d539672
Mobile:
