FIX: do not downgrade trust level if all requirements are met #25953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the trust level method is calculating trust level based on maximum value from: - locked trust level - group automatic trust level - previously granted trust level by admin https://github.com/discourse/discourse/blob/main/lib/trust_level.rb#L33 Let's say the user belongs to groups with automatic trust level 1 and in the meantime meets all criteria to get trust level 2. Each time, a user is removed from a group with automatic trust_level 1, they will be downgraded to trust_level 1 and promoted to trust_level 2 https://github.com/discourse/discourse/blob/120a2f70a9ea3b08a39fc1fbb251f59ecf968cde/lib/promotion.rb#L142 This will cause duplicated promotion messages. Therefore, we have to check if the user meets the criteria, before downgrading.
lis2
changed the title
CvX
approved these changes
Feb 29, 2024
VeroFess
added a commit
to VeroFess/discourse_path_s3_support
that referenced
this pull request
Mar 3, 2024
FIX: down downgrade trust level if all requirements are met. (discourse#25953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the trust level method is calculating trust level based on maximum value from:
https://github.com/discourse/discourse/blob/main/lib/trust_level.rb#L33
Let's say the user belongs to groups with automatic trust level 1 and in the meantime meets all criteria to get trust level 2.
Each time, a user is removed from a group with automatic trust_level 1, they will be downgraded to trust_level 1 and immediately promoted to trust_level 2
discourse/lib/promotion.rb
Line 142 in 120a2f7
This will cause duplicated promotion messages.
Therefore, we have to check if the user meets the criteria, before downgrading.